Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect calculation in indexTree.treePosToPath operation #150

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Feb 22, 2024

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 212 lines in your changes are missing coverage. Please review.

Comparison is base (9f70093) 42.45% compared to head (955f7bd) 42.30%.

Files Patch % Lines
Tests/Integration/TreeIntegrationTests.swift 0.00% 122 Missing ⚠️
Tests/Integration/IntegrationHelper.swift 0.00% 90 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   42.45%   42.30%   -0.15%     
==========================================
  Files         104      104              
  Lines       24328    24425      +97     
==========================================
+ Hits        10328    10333       +5     
- Misses      14000    14092      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit 4fc579b into main Feb 23, 2024
3 checks passed
@humdrum humdrum deleted the fix-incorrect-tree-path branch February 23, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants