Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove async call of subscribe callbacks #156

Merged
merged 1 commit into from
Mar 28, 2024
Merged

remove async call of subscribe callbacks #156

merged 1 commit into from
Mar 28, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Mar 28, 2024

What this PR does / why we need it:
DocEvent should be emitted synchronously with applying changes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum self-assigned this Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 41.84%. Comparing base (6cf3cb8) to head (e2d3c03).

Files Patch % Lines
Sources/Document/Document.swift 33.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   41.83%   41.84%           
=======================================
  Files         104      104           
  Lines       24681    24669   -12     
=======================================
- Hits        10326    10322    -4     
+ Misses      14355    14347    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit d80a7a2 into main Mar 28, 2024
3 checks passed
@humdrum humdrum deleted the subscribe_closure branch March 28, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant