Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tree concurrency tests #169

Merged
merged 4 commits into from
May 21, 2024
Merged

Add Tree concurrency tests #169

merged 4 commits into from
May 21, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented May 20, 2024

What this PR does / why we need it:

  • Add Tree concurrency tests yorkie-js-sdk#792
  • remove syncShutdownGracefully() in Client.
    • syncShutdownGracefully() caused hangs when performing Tree concurrent tests.
    • close connections are performed with rpcClient.channel.close() so, It's redundant.
  • Create some deepcopy() function to classes.
    • The initial Tree root is used repeatedly with the Tree concurrent test.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum self-assigned this May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 718 lines in your changes are missing coverage. Please review.

Project coverage is 38.89%. Comparing base (97ed0c8) to head (3018468).

Files Patch % Lines
Tests/Integration/TreeConcurrencyTests.swift 0.00% 707 Missing ⚠️
Sources/Document/Change/ChangeContext.swift 0.00% 5 Missing ⚠️
Sources/Document/Json/JSONTree.swift 0.00% 5 Missing ⚠️
Sources/Core/Client.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   40.42%   38.89%   -1.54%     
==========================================
  Files         104      105       +1     
  Lines       18179    18895     +716     
==========================================
  Hits         7349     7349              
- Misses      10830    11546     +716     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit e309688 into main May 21, 2024
3 checks passed
@humdrum humdrum deleted the tree-concurrency branch May 21, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants