Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace selection with presence #577

Closed
wants to merge 3 commits into from

Conversation

hackerwins
Copy link
Member

What this PR does / why we need it?

Replace selection with presence

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #577 (9329a6f) into main (9e0c431) will decrease coverage by 0.91%.
The diff coverage is 54.45%.

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   88.30%   87.39%   -0.91%     
==========================================
  Files          81       81              
  Lines        7916     7935      +19     
  Branches      805      818      +13     
==========================================
- Hits         6990     6935      -55     
- Misses        613      688      +75     
+ Partials      313      312       -1     
Impacted Files Coverage Δ
src/client/client.ts 77.08% <ø> (-0.08%) ⬇️
src/document/json/tree.ts 54.85% <0.00%> (ø)
src/document/operation/select_operation.ts 0.00% <ø> (-50.00%) ⬇️
src/document/operation/style_operation.ts 54.16% <ø> (ø)
src/document/presence/presence.ts 83.33% <ø> (ø)
src/document/time/ticket.ts 83.78% <0.00%> (-2.33%) ⬇️
src/yorkie.ts 100.00% <ø> (ø)
test/integration/document_test.ts 98.98% <ø> (-0.01%) ⬇️
test/unit/document/document_test.ts 95.86% <ø> (-0.15%) ⬇️
src/document/json/text.ts 32.89% <27.77%> (-12.56%) ⬇️
... and 10 more

... and 1 file with indirect coverage changes

@hackerwins hackerwins force-pushed the replace-selection-with-presence branch from 9329a6f to 8c63f98 Compare July 19, 2023 10:38
@hackerwins hackerwins closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant