Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Protocol Changes for Tree.RemoveStyle #755

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Conversation

raararaara
Copy link
Contributor

@raararaara raararaara commented Feb 22, 2024

What this PR does / why we need it?

This PR reflects protocol changes for the Tree.RemoveStyle patch on #745.

Any background context you want to provide?

  • Proto file and converter were modified to reflect requirements related to the Tree.RemoveStyle patch.
  • Added related test code.

What are the relevant tickets?

Related #745, yorkie-team/yorkie#748

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (0bc7ce1) to head (64f74fb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
+ Coverage   81.50%   81.77%   +0.26%     
==========================================
  Files          59       59              
  Lines        4348     4357       +9     
  Branches      853      856       +3     
==========================================
+ Hits         3544     3563      +19     
+ Misses        543      537       -6     
+ Partials      261      257       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raararaara raararaara marked this pull request as ready for review February 22, 2024 14:36
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raararaara Is there no need to add related test codes?

Please also add a brief explanation.

What this PR does / why we need it?
Any background context you want to provide?
What are the relevant tickets?
Related #745, yorkie-team/yorkie#748

@raararaara
Copy link
Contributor Author

@raararaara Is there no need to add related test codes?

Please also add a brief explanation.

What this PR does / why we need it?
Any background context you want to provide?
What are the relevant tickets?
Related #745, yorkie-team/yorkie#748

I have added the relavent test code and added a brief explanation.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hackerwins hackerwins merged commit 2af8a0c into main Mar 14, 2024
2 checks passed
@hackerwins hackerwins deleted the tree-remove-style branch March 14, 2024 09:37
@hackerwins hackerwins changed the title Implement Protocol Changes for Tree.RemoveStyle Feature Support Implement Protocol Changes for Tree.RemoveStyle Mar 14, 2024
@raararaara raararaara added the protocol changed 📝 Whether the protocol has changed label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol changed 📝 Whether the protocol has changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants