Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iOS SDK Document to v 0.4.24 #163

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Update iOS SDK Document to v 0.4.24 #163

merged 1 commit into from
Aug 29, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Aug 28, 2024

What this PR does / why we need it?

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features

    • Updated iOS SDK version to align with Android version.
    • Simplified client initialization with a direct URL format.
    • Enhanced document update method for improved data handling.
    • New subscription methods for connection and synchronization events.
    • Added Logger options for adjustable log verbosity.
  • Documentation

    • Improved clarity and usability in iOS SDK documentation.
    • Updated terminology for synchronization modes and document management.
    • Expanded sections on presence management and event subscriptions.

@humdrum humdrum self-assigned this Aug 28, 2024
Copy link

coderabbitai bot commented Aug 28, 2024

Walkthrough

The changes encompass updates to the environment variable configuration for the Yorkie SDK and significant modifications to the iOS SDK documentation. The iOS version number was incremented to match the Android version. Documentation updates include simplified client initialization, enhanced document management features, and new subscription methods for connection and synchronization events. Logger options were also introduced to improve debugging capabilities.

Changes

Files Change Summary
.env Updated the iOS version number of the Yorkie SDK from 0.4.17 to 0.4.24.
docs/getting-started/with-ios-sdk.mdx Simplified Client initialization, updated document update method for handling collections, and improved access to document properties.
docs/ios-sdk.mdx Streamlined Client creation, updated synchronization terminology, expanded presence management, added subscription methods for connection and synchronization events, and introduced Logger options.

Poem

🐰 In the garden, changes bloom,
With Yorkie SDK, there's more room.
A hop to sync, a leap to connect,
New paths to explore, what perfect respect!
With logs that shine and docs so bright,
Let’s code and play, from morning to night! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4934a0d and 81f5fa4.

Files selected for processing (3)
  • .env (1 hunks)
  • docs/getting-started/with-ios-sdk.mdx (2 hunks)
  • docs/ios-sdk.mdx (12 hunks)
Additional context used
LanguageTool
docs/ios-sdk.mdx

[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...argument is options. - initialPresence: Sets the initial presence of the client...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~235-~235: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...is modified, change events are triggered and you can subscribe to these events using...

(COMMA_COMPOUND_SENTENCE)


[uncategorized] ~340-~340: Loose punctuation mark.
Context: ...s four SyncModes: - SyncMode.realtime: Local changes are automatically pushed ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~342-~342: Loose punctuation mark.
Context: ...e server. - SyncMode.realtimePushOnly: Only local changes are pushed, and remo...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~344-~344: Loose punctuation mark.
Context: ...ot pulled. - SyncMode.realtimeSyncOff: Changes are not synchronized, but the w...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~346-~346: Loose punctuation mark.
Context: ...eam remains active. - SyncMode.manual: Synchronization no longer occurs in rea...

(UNLIKELY_OPENING_PUNCTUATION)

Additional comments not posted (15)
.env (1)

4-4: LGTM!

The iOS version number has been correctly updated.

The code changes are approved.

docs/getting-started/with-ios-sdk.mdx (4)

30-30: LGTM!

The client instantiation has been simplified and improves readability.

The code changes are approved.


52-55: LGTM!

The document update method now includes a second parameter, enhancing its functionality.

The code changes are approved.


61-67: LGTM!

The method for accessing document properties has been simplified, improving readability and usability.

The code changes are approved.


64-67: LGTM!

The method for accessing document properties has been simplified, improving readability and usability.

The code changes are approved.

docs/ios-sdk.mdx (10)

18-27: LGTM!

The client instantiation has been simplified and improves readability.

The code changes are approved.


36-42: LGTM!

The document creation method has been slightly rephrased for clarity.

The code changes are approved.


55-60: LGTM!

The options for attaching a document have been updated to reflect a more structured approach to synchronization modes.

The code changes are approved.

Tools
LanguageTool

[uncategorized] ~56-~56: Loose punctuation mark.
Context: ...argument is options. - initialPresence: Sets the initial presence of the client...

(UNLIKELY_OPENING_PUNCTUATION)


100-101: LGTM!

The presence update method has been clarified, improving clarity and usability.

The code changes are approved.


132-139: LGTM!

The presence subscription method has been clarified, improving clarity and usability.

The code changes are approved.


230-236: LGTM!

The document subscription method has been clarified, improving clarity and usability.

The code changes are approved.

Tools
LanguageTool

[uncategorized] ~235-~235: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...is modified, change events are triggered and you can subscribe to these events using...

(COMMA_COMPOUND_SENTENCE)


295-312: LGTM!

The connection status subscription method has been introduced, enhancing the robustness of the SDK.

The code changes are approved.


316-329: LGTM!

The synchronization status subscription method has been introduced, enhancing the robustness of the SDK.

The code changes are approved.


336-360: LGTM!

The synchronization mode change method has been clarified, improving clarity and usability.

The code changes are approved.

Tools
LanguageTool

[uncategorized] ~340-~340: Loose punctuation mark.
Context: ...s four SyncModes: - SyncMode.realtime: Local changes are automatically pushed ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~342-~342: Loose punctuation mark.
Context: ...e server. - SyncMode.realtimePushOnly: Only local changes are pushed, and remo...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~344-~344: Loose punctuation mark.
Context: ...ot pulled. - SyncMode.realtimeSyncOff: Changes are not synchronized, but the w...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~346-~346: Loose punctuation mark.
Context: ...eam remains active. - SyncMode.manual: Synchronization no longer occurs in rea...

(UNLIKELY_OPENING_PUNCTUATION)


456-476: LGTM!

The logger options have been introduced, improving debugging capabilities.

The code changes are approved.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit d6ec525 into main Aug 29, 2024
2 checks passed
@hackerwins hackerwins deleted the update_ios_0_4_24 branch August 29, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants