-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nginx-ingress-controller option #1022
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,7 +1,11 @@ | ||||||||||||||||||||||
apiVersion: networking.k8s.io/v1 | ||||||||||||||||||||||
kind: Ingress | ||||||||||||||||||||||
metadata: | ||||||||||||||||||||||
{{ if .Values.ingress.nginx.enabled }} | ||||||||||||||||||||||
name: ingress-nginx | ||||||||||||||||||||||
{{ else }} | ||||||||||||||||||||||
name: {{ .Values.yorkie.name }} | ||||||||||||||||||||||
{{ end }} | ||||||||||||||||||||||
Comment on lines
+4
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix indentation for consistent YAML structure The conditional block for naming has inconsistent indentation, which could lead to YAML parsing errors. Please adjust the indentation to ensure all lines are properly aligned. Apply this diff to fix the indentation: {{ if .Values.ingress.nginx.enabled }}
- name: ingress-nginx
- {{ else }}
+name: ingress-nginx
+{{ else }}
name: {{ .Values.yorkie.name }}
- {{ end }}
+{{ end }} 📝 Committable suggestion
Suggested change
🧰 Tools🪛 yamllint
|
||||||||||||||||||||||
namespace: {{ .Values.yorkie.namespace }} | ||||||||||||||||||||||
{{ if .Values.ingress.awsAlb.enabled }} | ||||||||||||||||||||||
annotations: | ||||||||||||||||||||||
|
@@ -27,14 +31,18 @@ metadata: | |||||||||||||||||||||
# If the health check fails, NCP ALB will not route the traffic to the service | ||||||||||||||||||||||
alb.ingress.kubernetes.io/healthcheck-path: /healthz | ||||||||||||||||||||||
{{ end }} | ||||||||||||||||||||||
{{ if .Values.ingress.nginx.enabled }} | ||||||||||||||||||||||
annotations: | ||||||||||||||||||||||
nginx.ingress.kubernetes.io/rewrite-target: / | ||||||||||||||||||||||
kubernetes.io/ingress.class: "nginx" | ||||||||||||||||||||||
{{ end }} | ||||||||||||||||||||||
spec: | ||||||||||||||||||||||
ingressClassName: {{ .Values.ingress.ingressClassName }} | ||||||||||||||||||||||
rules: | ||||||||||||||||||||||
{{ if .Values.ingress.hosts.enabled }} | ||||||||||||||||||||||
- host: {{ .Values.ingress.hosts.apiHost }} | ||||||||||||||||||||||
http: | ||||||||||||||||||||||
{{ end }} | ||||||||||||||||||||||
{{ if not .Values.ingress.hosts.enabled }} | ||||||||||||||||||||||
{{ else }} | ||||||||||||||||||||||
- http: | ||||||||||||||||||||||
{{ end }} | ||||||||||||||||||||||
paths: | ||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like ingress name is just
ingress-nginx
while we uses{{ .Values.yorkie.name }}
for previous settings.