Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CLI TLS configuration to HTTP2 #742

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Change CLI TLS configuration to HTTP2 #742

merged 2 commits into from
Jan 3, 2024

Conversation

krapie
Copy link
Member

@krapie krapie commented Jan 3, 2024

What this PR does / why we need it:

Change CLI TLS configuration to HTTP2.

There were two reasons for this bug:

  • CLI was not requesting with HTTPS (default scheme was HTTP).
  • HTTP/TLS version between AWS LB/TG(HTTP/2) and CLI request(HTTP/1.1) was different.

Therefore, I have updated:

  • Default HTTP scheme configuration to either HTTP or HTTPS based on client configuration(--insecure flag).
  • HTTP client transport protocol to explicit HTTP2.

Which issue(s) this PR fixes:

Fixes #733

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@krapie krapie added the bug 🐞 Something isn't working label Jan 3, 2024
@krapie krapie requested a review from hackerwins January 3, 2024 03:22
@krapie krapie self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8e6e205) 49.27% compared to head (5736314) 49.25%.

Files Patch % Lines
client/client.go 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   49.27%   49.25%   -0.02%     
==========================================
  Files          69       69              
  Lines       10081    10084       +3     
==========================================
  Hits         4967     4967              
- Misses       4598     4601       +3     
  Partials      516      516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 258cb1e into main Jan 3, 2024
3 checks passed
@hackerwins hackerwins deleted the fix-cli branch January 3, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After migrating gRPC to connect-rpc, CLI doesn't work with api.yorkie.dev:443
2 participants