Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pubsub] Prevent cancellation on ack #291

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[pubsub] Prevent cancellation on ack #291

merged 1 commit into from
Aug 1, 2024

Conversation

yoshidan
Copy link
Owner

@yoshidan yoshidan changed the title Split gRPC connection for streaming_pull [pubsub] Avoid cancellation by connection close on ack Jul 31, 2024
@yoshidan yoshidan changed the title [pubsub] Avoid cancellation by connection close on ack [pubsub] Avoid cancellation by closed connection on ack Jul 31, 2024
@yoshidan yoshidan changed the title [pubsub] Avoid cancellation by closed connection on ack [pubsub] Prevent closed connection from cancelling ack Jul 31, 2024
@yoshidan yoshidan changed the title [pubsub] Prevent closed connection from cancelling ack [pubsub] Prevent cancellation on ack Jul 31, 2024
@yoshidan yoshidan added the safe to test safe to test label Jul 31, 2024
@yoshidan yoshidan merged commit 4c8e0c8 into main Aug 1, 2024
8 of 9 checks passed
@yoshidan yoshidan deleted the patch-pubsub branch October 2, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
safe to test safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yoshidan