Elm it up #30
Merged
Elm it up #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enables `barracks` to be used as the core of `choo`. It solves the previous questions that were left unanswered in the FAQ - [x] write docs - [x] write code - [x] write tests Commits ======= - fixup! allow extending of state - fixup! _send change arg order - fixup! pass createSend() instead of send() - fixup! perfffff for handlers oi - fixup! if statements? nah - fixup! actually pass the argument hey - fixup! make tests pass oi - fixup! update docs for createSend() - fixup! bump travis - fixup! add model tests - fixup! more start tests - fixup! document internals - fixup! test nested effects - fixup! test subscriptions - fixup! add done() to subs - fixup! add onState tests - fixup! add onAction test - fixup! add namespaced tests
|
I think we're good - merging! ✨ |
|
Oh PS this is a breaking change hah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a complete rewrite of
barracks, catered for choo; it now has a better split out architecture that caters to all forms of async problems. In essence it's quite similar tochoo@2; but adds composition foreffects(as per choojs/choo#34).There's also a notion of
handlersthat can react to state changes, errors and actions (as per choojs/choo#15). This API is slightly awkward I've found that each handler is slightly different; but I reckon they're good enough. The only point of debate would be whether or not to make thecallerargument an array to display the full stack trace; and to add thecallerto theonErrorhandler. The latter adding a reasonable source of complexity for information that's available already despite in a shittier format. Input here would be heaps valued.Also we're not 100% test covered (sitting closer to 70%); but I've run this off every example in
chooand it seems to work soooo ✨I'd suggest reading the README.md file for a full overview of the new API. Thanks!