Add MediaType::to_docker_v2s2 for Docker Image Manifest V2 Schema 2 equivalents
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nokome, thank you for this PR! May I ask you to sign-off your commits via
Yep I'd prefer that. |
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 24.21% 24.09% -0.13%
==========================================
Files 20 20
Lines 1503 1511 +8
Branches 741 742 +1
==========================================
Hits 364 364
- Misses 495 503 +8
Partials 644 644 |
nokome
changed the title
MediaType::to_v2s2 for Docker Image Manifest V2 Schema 2 equivalentsMediaType::to_docker_v2s2 for Docker Image Manifest V2 Schema 2 equivalents
|
@saschagrunert thanks for your quick attention to this. I have signed off the commit and renamed to |
|
@nokome have you pushed the changes, I still see |
… equivalents Signed-off-by: Nokome Bentley <nokome@stenci.la>
Yeah, sorry about that, I hadn't staged the changes before |
saschagrunert
approved these changes
Jun 9, 2022
utam0k
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105.
I chose
to_v2s2over the shorterto_docker_v2s2after I noted thatv2s2is the shorthand used bypodman. But happy to change to the more explicitto_docker_v2s2is you feel that is appropriate.