Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename closId -> closID. #128

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Rename closId -> closID. #128

merged 1 commit into from
Apr 25, 2023

Conversation

ipuustin
Copy link
Contributor

The spec defines the variable as closID. Without this patch the clos_id value is always None.

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #128 (24d3a90) into main (d540c0c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   24.39%   24.39%           
=======================================
  Files          21       21           
  Lines        1644     1644           
  Branches      816      816           
=======================================
  Hits          401      401           
  Misses        546      546           
  Partials      697      697           

@utam0k
Copy link
Member

utam0k commented Apr 23, 2023

Sorry but please wait for #129

Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
@ipuustin
Copy link
Contributor Author

Rebased.

@utam0k utam0k merged commit a46cd8b into youki-dev:main Apr 25, 2023
@ipuustin ipuustin deleted the rename-closid branch April 26, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants