enhancement: Handle "mount" and "network" for LinuxNamespaceType #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation of LinuxNamespaceType::try_from only recognizes "mnt" and "net" for Mount and Network namespaces respectively. This commit expands accepted strings to include "mount" and "network" for better compatibility with potential use cases. Fixes youki-dev#186 Signed-off-by: Alex Lyn <alex.lyn@antgroup.com>
|
Hi @saschagrunert @utam0k PTAL! Thx very much |
saschagrunert
approved these changes
Jul 11, 2024
utam0k
reviewed
Jul 11, 2024
| @@ -828,13 +828,13 @@ impl TryFrom<&str> for LinuxNamespaceType { | |||
|
|
|||
| fn try_from(namespace: &str) -> Result<Self, Self::Error> { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, I use the same way LinuxNamespace::try_from(ns_str)? in my project too.
Thx @utam0k @saschagrunert and the great project oci-spec-rs
utam0k
approved these changes
Jul 11, 2024
|
Thanks, @Apokleos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of LinuxNamespaceType::try_from only recognizes "mnt" and "net" for Mount and Network namespaces respectively. This commit expands accepted strings to include "mount" and "network" for better compatibility with potential use cases.
Fixes #186