Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying Dependencies with tilde requirements #191

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Apokleos
Copy link
Contributor

Specify a minimal version for regex and once_cell with some ability to update and enhance compatibility for other projects which depends on these crates.

Fixes #190

@Apokleos
Copy link
Contributor Author

Hi, @saschagrunert as talked with @utam0k I push this commit to enhance it. PTAL! thx

@Apokleos
Copy link
Contributor Author

Apokleos commented Jul 16, 2024

FYI @utam0k @saschagrunert PTAL ! thx
I have no the ability to label the commit for CI checking. Could you please help add labels ?

@keisku
Copy link
Contributor

keisku commented Jul 16, 2024

@Apokleos Can you tell us what project depends on oci-spec-rs? I'm curious why the project is ok with regex 1.10.3, but not regex 1.10.5. The changelog of regex doesn't seem to contain breaking change between 1.10.3..1.10.5.

@Apokleos
Copy link
Contributor Author

@Apokleos Can you tell us what project depends on oci-spec-rs? I'm curious why the project is ok with regex 1.10.3, but not regex 1.10.5. The changelog of regex doesn't seem to contain breaking change between 1.10.3..1.10.5.

Yeah, you're right. I'll correct it ASAP. Thx for your.

Specify a minimal version for regex and once_cell with
some ability to update and enhance compatibility for
other projects which depends on these crates.

Fixes youki-dev#190

Signed-off-by: Alex Lyn <alex.lyn@antgroup.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.99%. Comparing base (a3d8805) to head (8e0dc98).
Report is 23 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   25.91%   26.99%   +1.07%     
==========================================
  Files          23       23              
  Lines        2473     2615     +142     
  Branches     1367     1443      +76     
==========================================
+ Hits          641      706      +65     
- Misses        861      873      +12     
- Partials      971     1036      +65     

@utam0k utam0k merged commit 75dea18 into youki-dev:main Jul 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disccuss: Regex and once_cell with high version might cause compatibility issues
5 participants