Add devcontainer #193
Merged
Add devcontainer #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musaprg
force-pushed
the
add-devcontainer
branch
from
7eeaf24
to
c1c9a62
Compare
musaprg
force-pushed
the
add-devcontainer
branch
2 times, most recently
from
f2f4f30
to
6ea96f7
Compare
Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
musaprg
force-pushed
the
add-devcontainer
branch
from
6ea96f7
to
3631883
Compare
|
Thanks. Please tell me why you want to align with the dependencies of youki. |
@utam0k Hi. I've just referred to the youki's one because it's already used and worked well, but we don't have a reason to align its dependencies with the youki's one. This change should not have unnecessary lines when I brought it to oci-spec-rs, but let me check again. |
Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
|
I double-checked and realized that most of them were unnecessary lines. I applied the following changes in 129aa9e and confirmed that
Could you check it again? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a devcontainer based on the one in the
containers/youki. This makes development or test execution easier on non-Linux environments.