Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Builder for features structures #199

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

musaprg
Copy link
Contributor

@musaprg musaprg commented Aug 17, 2024

The fields of structures used by Features struct are private, so we need Builder, Getters, and Setters traits to construct the Features struct properly. This PR adds the necessary traits for all structures related to Feature struct.

Screenshot 2024-08-18 at 2 12 46

related: #184

Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k utam0k merged commit de8fd72 into youki-dev:main Aug 18, 2024
14 of 15 checks passed
@musaprg musaprg deleted the add-builder-for-features-structures branch August 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants