Fix GHA invoking cargo audit #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 26.61% 29.15% +2.54%
==========================================
Files 24 26 +2
Lines 2788 3159 +371
Branches 1516 1671 +155
==========================================
+ Hits 742 921 +179
- Misses 948 1021 +73
- Partials 1098 1217 +119 |
We recently got a major version update of the audit-check GHA. This version invokes: ```console cargo audit --json --file ./Cargo.lock ```` Which fails, because we don't have a `Cargo.lock` file. This commit makes sure the `Cargo.lock` is present prior to invoking `cargo audit`. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
saschagrunert
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind ci
What this PR does / why we need it:
The security audit GHA is failing
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
We recently got a major version update of the audit-check GHA.
This version invokes:
cargo audit --json --file ./Cargo.lockWhich fails, because we don't have a
Cargo.lockfile.This commit makes sure the
Cargo.lockis present prior to invokingcargo audit.Does this PR introduce a user-facing change?