Remove conditional compilation of spec fields #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec objects are not platform-dependent. There are fields that are not applicable for certain runtime environments, but they should still be available to programs that are not runtimes. Runtime implementations are free to ignore fields they can't process. Signed-off-by: Markus Rudy <mr@edgeless.systems>
saschagrunert
approved these changes
Oct 24, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 26.61% 29.02% +2.41%
==========================================
Files 24 26 +2
Lines 2788 3135 +347
Branches 1516 1668 +152
==========================================
+ Hits 742 910 +168
- Misses 948 1004 +56
- Partials 1098 1221 +123 |
flavio
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
The spec objects are not platform-dependent. There are fields that are not applicable for certain runtime environments, but they should still be available to programs that are not runtimes. Runtime implementations are free to ignore fields they can't process.
Which issue(s) this PR fixes:
Fixes #243
Special notes for your reviewer:
Does this PR introduce a user-facing change?