Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to load an actual spec #78

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Add tests to load an actual spec #78

merged 3 commits into from
Oct 6, 2021

Commits on Oct 5, 2021

  1. Adds a test to run actual json spec. 

    Without this, we will only test what's generated by our code, not what is expected.
    @yihuaf
    yihuaf committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    f45fc12 View commit details
    Browse the repository at this point in the history

  2. Revert "change hook timeout from Option<int64> to Option<time::Durati… 

    …on>"

This reverts commit 36cf113.

The hook timeout should be i64, not Duration. Duration implies a much
finer structure, but the field indicates specifically the number of
seconds before timeout. Duration is not the right choice here.
Reverting back to i64.
    @yihuaf
    yihuaf committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    81d931e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. address review

    @yihuaf
    yihuaf committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    2297381 View commit details
    Browse the repository at this point in the history