Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing Setters trait to LinuxPids #84

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

knight42
Copy link
Contributor

@knight42 knight42 commented Dec 9, 2021

Signed-off-by: Jian Zeng anonymousknight96@gmail.com

Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
@Furisto
Copy link
Contributor

Furisto commented Dec 9, 2021

Looks good, but you need to do a cargo fmt.

Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
@knight42
Copy link
Contributor Author

@Furisto Hi! I have already formatted the code.

@codecov-commenter
Copy link

Codecov Report

Merging #84 (20619fc) into main (54c5e38) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   25.40%   25.30%   -0.11%     
==========================================
  Files          20       20              
  Lines        1464     1470       +6     
  Branches      710      709       -1     
==========================================
  Hits          372      372              
- Misses        456      463       +7     
+ Partials      636      635       -1     

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knight42 Thanks!

@utam0k utam0k merged commit 12dcd85 into youki-dev:main Dec 10, 2021
@knight42 knight42 deleted the fix/linuxpids-setter branch December 10, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants