fix: clippy

Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>

cgroups/src/v1/blkio.rs

@@ -77,7 +77,7 @@ impl Controller for Blkio {
     fn apply(controller_opt: &ControllerOpt, cgroup_root: &Path) -> Result<()> {
         log::debug!("Apply blkio cgroup config");
 
-        if let Some(blkio) = Self::needs_to_handle(&controller_opt) {
+        if let Some(blkio) = Self::needs_to_handle(controller_opt) {
             Self::apply(cgroup_root, blkio)?;
         }
 

cgroups/src/v1/cpu.rs

@@ -25,7 +25,7 @@ impl Controller for Cpu {
     fn apply(controller_opt: &ControllerOpt, cgroup_root: &Path) -> Result<()> {
         log::debug!("Apply Cpu cgroup config");
 
-        if let Some(cpu) = Self::needs_to_handle(&controller_opt) {
+        if let Some(cpu) = Self::needs_to_handle(controller_opt) {
             Self::apply(cgroup_root, cpu).context("failed to apply cpu resource restrictions")?;
         }
 

cgroups/src/v1/cpuset.rs

@@ -30,7 +30,7 @@ impl Controller for CpuSet {
     fn apply(controller_opt: &ControllerOpt, cgroup_path: &Path) -> Result<()> {
         log::debug!("Apply CpuSet cgroup config");
 
-        if let Some(cpuset) = Self::needs_to_handle(&controller_opt) {
+        if let Some(cpuset) = Self::needs_to_handle(controller_opt) {
             Self::apply(cgroup_path, cpuset)
                 .context("failed to apply cpuset resource restrictions")?;
         }

cgroups/src/v1/devices.rs

@@ -99,7 +99,7 @@ mod tests {
             },
             LinuxDeviceCgroup {
                 allow: true,
-                typ: Some(LinuxDeviceType::B),
+                typ: Some(LinuxDeviceType::A),
                 major: None,
                 minor: Some(200),
                 access: "rwm".to_string().into(),

cgroups/src/v1/freezer.rs

@@ -25,7 +25,7 @@ impl Controller for Freezer {
         log::debug!("Apply Freezer cgroup config");
         create_dir_all(&cgroup_root)?;
 
-        if let Some(freezer_state) = Self::needs_to_handle(&controller_opt) {
+        if let Some(freezer_state) = Self::needs_to_handle(controller_opt) {
             Self::apply(freezer_state, cgroup_root).context("failed to appyl freezer")?;
         }
 

cgroups/src/v1/hugetlb.rs

@@ -18,7 +18,7 @@ impl Controller for HugeTlb {
     fn apply(controller_opt: &ControllerOpt, cgroup_root: &std::path::Path) -> Result<()> {
         log::debug!("Apply Hugetlb cgroup config");
 
-        if let Some(hugepage_limits) = Self::needs_to_handle(&controller_opt) {
+        if let Some(hugepage_limits) = Self::needs_to_handle(controller_opt) {
             for hugetlb in hugepage_limits {
                 Self::apply(cgroup_root, hugetlb)
                     .context("failed to apply hugetlb resource restrictions")?

cgroups/src/v1/manager.rs

@@ -129,7 +129,7 @@ impl CgroupManager for Manager {
     }
 
     fn apply(&self, controller_opt: &ControllerOpt) -> Result<()> {
-        for subsys in self.get_required_controllers(&controller_opt)? {
+        for subsys in self.get_required_controllers(controller_opt)? {
             match subsys.0 {
                 CtrlType::Cpu => Cpu::apply(controller_opt, subsys.1)?,
                 CtrlType::CpuAcct => CpuAcct::apply(controller_opt, subsys.1)?,

cgroups/src/v1/memory.rs

@@ -51,7 +51,7 @@ impl Controller for Memory {
     fn apply(controller_opt: &ControllerOpt, cgroup_root: &Path) -> Result<()> {
         log::debug!("Apply Memory cgroup config");
 
-        if let Some(memory) = Self::needs_to_handle(&controller_opt) {
+        if let Some(memory) = Self::needs_to_handle(controller_opt) {
             let reservation = memory.reservation.unwrap_or(0);
 
             Self::apply(memory, cgroup_root)?;
@@ -440,7 +440,7 @@ mod tests {
 
 
             // clone to avoid use of moved value later on
-            let memory_limits = linux_memory.clone();
+            let memory_limits = linux_memory;
 
             let linux_resources = LinuxResources {
                 devices: Some(vec![]),
@@ -456,7 +456,7 @@ mod tests {
 
         let controller_opt = ControllerOpt {
             resources: linux_resources,
-            disable_oom_killer: disable_oom_killer,
+            disable_oom_killer,
             ..Default::default()
         };
 

cgroups/src/v1/network_classifier.rs

@@ -14,7 +14,7 @@ impl Controller for NetworkClassifier {
     fn apply(controller_opt: &ControllerOpt, cgroup_root: &Path) -> Result<()> {
         log::debug!("Apply NetworkClassifier cgroup config");
 
-        if let Some(network) = Self::needs_to_handle(&controller_opt) {
+        if let Some(network) = Self::needs_to_handle(controller_opt) {
             Self::apply(cgroup_root, network)
                 .context("failed to apply network classifier resource restrictions")?;
         }

cgroups/src/v1/network_priority.rs

@@ -14,7 +14,7 @@ impl Controller for NetworkPriority {
     fn apply(controller_opt: &ControllerOpt, cgroup_root: &Path) -> Result<()> {
         log::debug!("Apply NetworkPriority cgroup config");
 
-        if let Some(network) = Self::needs_to_handle(&controller_opt) {
+        if let Some(network) = Self::needs_to_handle(controller_opt) {
             Self::apply(cgroup_root, network)
                 .context("failed to apply network priority resource restrictions")?;
         }

cgroups/src/v2/devices/program.rs

@@ -249,7 +249,7 @@ fn bpf_cgroup_dev_ctx(
 mod tests {
     use super::*;
 
-    fn build_bpf_program(rules: &Option<Vec<oci_spec::LinuxDeviceCgroup>>) -> Result<Program> {
+    fn build_bpf_program(rules: &Option<Vec<LinuxDeviceCgroup>>) -> Result<Program> {
         let mut em = crate::v2::devices::emulator::Emulator::with_default_allow(false);
         if let Some(rules) = rules {
             em.add_rules(rules)?;

cgroups/src/v2/unified.rs

@@ -77,7 +77,7 @@ mod tests {
         };
 
         let controller_opt = ControllerOpt {
-            resources: resources,
+            resources,
             ..Default::default()
         };
 
@@ -112,7 +112,7 @@ mod tests {
         };
 
         let controller_opt = ControllerOpt {
-            resources: resources,
+            resources,
             ..Default::default()
         };
 
@@ -143,7 +143,7 @@ mod tests {
         };
 
         let controller_opt = ControllerOpt {
-            resources: resources,
+            resources,
             ..Default::default()
         };