Add TODO comments for self-notes

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
youki-dev · Jan 17, 2024 · 16dedc2 · 16dedc2
1 parent eca3bbb
commit 16dedc2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/tests/contest/contest/src/main.rs b/tests/contest/contest/src/main.rs
@@ -102,6 +102,7 @@ fn main() -> Result<()> {
     let ro_paths = get_ro_paths_test();
     let hostname = get_hostname_test();
     let mounts_recursive = get_mounts_recursive_test();
+    #[allow(unused_variables)]
     let domainname = get_domainname_tests();
     let intel_rdt = get_intel_rdt_test();
     let sysctl = get_sysctl_test();
@@ -123,7 +124,7 @@ fn main() -> Result<()> {
     tm.add_test_group(Box::new(ro_paths));
     tm.add_test_group(Box::new(hostname));
     tm.add_test_group(Box::new(mounts_recursive));
-    tm.add_test_group(Box::new(domainname));
+    // tm.add_test_group(Box::new(domainname)); // TODO (YJDoc2) fix in #2616
     tm.add_test_group(Box::new(intel_rdt));
     tm.add_test_group(Box::new(sysctl));
 

diff --git a/tests/contest/runtimetest/Cargo.toml b/tests/contest/runtimetest/Cargo.toml
@@ -7,5 +7,5 @@ edition = "2021"
 oci-spec = { version = "0.6.4", features = ["runtime"] }
 nix = "0.27.1"
 anyhow = "1.0"
-libc = "0.2.139"
+libc = "0.2.139" # TODO (YJDoc2) upgrade to latest
 
diff --git a/tests/contest/runtimetest/src/tests.rs b/tests/contest/runtimetest/src/tests.rs
@@ -92,6 +92,7 @@ pub fn validate_domainname(spec: &Spec) {
         const MAX_DOMAINNAME_SIZE: usize = 254;
         let actual_domainname: [i8; MAX_DOMAINNAME_SIZE] = [0; MAX_DOMAINNAME_SIZE];
 
+        // TODO (YJDoc2) : libc now has support for getdomainname, update this to use that
         let ret =
             unsafe { getdomainname(actual_domainname.as_ptr() as *mut i8, MAX_DOMAINNAME_SIZE) };
         if ret == -1 {