Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The container bundle path stored should be canonicalized when creating #1153

Closed
YJDoc2 opened this issue Aug 29, 2022 · 0 comments
Closed

The container bundle path stored should be canonicalized when creating #1153

YJDoc2 opened this issue Aug 29, 2022 · 0 comments
Assignees

Comments

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 29, 2022

Currently we store the bundle path for the container as-is given to the -b of the create command. The direct effect of this can be seen when using the list command :

ID                  PID    STATUS   BUNDLE      CREATED                    CREATOR
tutorial_container  15591  Created  ./tutorial  2022-08-29T11:10:11+05:30  root

The path should be canonicalized before storing, so we can get the proper path whenever we need it.

The problems with this can be that if any part of youki assumes that the bundle path is non-canonicalized, , and uses something else to do that, then it can fail.

This might also effect changes of #152 , namely made in pr #153 , so those must be tested.

The direct observable difference this will make can be seen with list command - when created new container with this change, the output will be similar to

ID                  PID    STATUS   BUNDLE                                   CREATED                    CREATOR
tutorial_container  19157  Created /complete/path/to/the/bundle/tutorial  2022-08-29T11:21:08+05:30  root

This is a suggestion, discussion is much welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants