Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle the rootfs path with bundle #153

Merged
merged 4 commits into from
Jul 22, 2021

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Jul 21, 2021

The rootfs path is not correctly handled. The safe guarded version of
the spec doesn't contain the canonicalized rootfs with the bundle path.
The solution here is to save the rootfs path with bundle path into the
safe guarded version of the spec.

fix #152

The rootfs path is not correctly handled. The safe guarded version of
the spec doesn't contain the canonicalized rootfs with the bundle path.
The solution here is to save the rootfs path with bundle path into the
safe guarded version of the spec.
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihuaf
Can I ask you to add unit tests for save and canonicalize_rootfs?

@yihuaf
Copy link
Collaborator Author

yihuaf commented Jul 21, 2021

@yihuaf
Can I ask you to add unit tests for save and canonicalize_rootfs?

Will do.

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is down, please fix it.

@utam0k utam0k merged commit 8daff03 into youki-dev:main Jul 22, 2021
@yihuaf yihuaf deleted the yihuaf/152 branch July 22, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec.root.path is not correctly handled
2 participants