Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that attempts is always 0 in delete_with_retry #1128

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

cyyzero
Copy link
Contributor

@cyyzero cyyzero commented Aug 18, 2022

In delete_with_retry, attempts is initialized as 0 and add itself every time remove_dir fails. It makes attempts always 0 and retries has no effect here.

Signed-off-by: Chen Yiyang cyyzero@qq.com

Signed-off-by: Chen Yiyang <cyyzero@qq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1128 (9656806) into main (06e9beb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   69.41%   69.40%   -0.01%     
==========================================
  Files         118      118              
  Lines       12443    12443              
==========================================
- Hits         8637     8636       -1     
- Misses       3806     3807       +1     

@cyyzero
Copy link
Contributor Author

cyyzero commented Aug 18, 2022

BTW, I found this bug when running commands below.

$ sudo youki run test
$ sudo youki pause test
$ sudo youki delete --force test

youki can't force delete a paused container , since container processes can't receive signal and quit until it is THAWED. Do I need to fix this issue? Maybe resume the processes before removing cgroup can fix it.

@cyyzero cyyzero requested a review from YJDoc2 August 22, 2022 07:38
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for your contribution!

@Furisto
Copy link
Collaborator

Furisto commented Aug 22, 2022

Thanks @cyyzero

@Furisto Furisto merged commit c16a1cb into youki-dev:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants