Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README issue links #1183

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Fix README issue links #1183

merged 1 commit into from
Sep 15, 2022

Conversation

LeoColomb
Copy link
Contributor

@LeoColomb LeoColomb commented Sep 11, 2022

Very tiny PR with just 2 fixes regarding the links in the README:

Signed-off-by: LeoColomb git@colombaro.fr

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #1183 (93ed68c) into main (0a195ab) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   69.41%   69.41%           
=======================================
  Files         118      118           
  Lines       12446    12446           
=======================================
  Hits         8640     8640           
  Misses       3806     3806           

@utam0k
Copy link
Member

utam0k commented Sep 12, 2022

Hi, @LeoColomb. Thanks for your first contribution. I'm glad to see your contribution. Can I ask you to put your signature on your commit?

$ git commit --amend --no-edit -s
$ git push -f origin HEAD

Signed-off-by: Léo Colombaro <git@colombaro.fr>
@LeoColomb
Copy link
Contributor Author

@utam0k Done 😊
I won't lie, this is quite annoying for 2 links in a README file...

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@utam0k utam0k merged commit 4deaeba into youki-dev:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants