Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.64.0 #1211

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Rust 1.64.0 #1211

merged 3 commits into from
Sep 27, 2022

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Sep 23, 2022

Fix: #1209

@utam0k utam0k marked this pull request as draft September 23, 2022 14:16
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
@codecov-commenter
Copy link

Codecov Report

Merging #1211 (36fb26f) into main (29faea1) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
- Coverage   69.31%   69.28%   -0.03%     
==========================================
  Files         118      118              
  Lines       12474    12474              
==========================================
- Hits         8646     8643       -3     
- Misses       3828     3831       +3     

@utam0k utam0k marked this pull request as ready for review September 24, 2022 04:32
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Sep 26, 2022

Hey, when I ran clippy manually, it also gives this warning :

warning: this expression borrows a value the compiler would automatically borrow
   --> crates/libcontainer/src/container/container.rs:108:29
    |
108 |                 return Some((&*user_name).to_owned());
    |                             ^^^^^^^^^^^^^ help: change this to: `(*user_name)`
    |
    = note: `#[warn(clippy::needless_borrow)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Otherwise, lgtm 👍

Signed-off-by: utam0k <k0ma@utam0k.jp>
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@YJDoc2 YJDoc2 merged commit a04f8f0 into youki-dev:main Sep 27, 2022
@YJDoc2 YJDoc2 mentioned this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support rust 1.64.0
3 participants