Improve the flow of the containerd test with youki

[utam0k]

No description provided.

[utam0k]

@YJDoc2 @Furisto May I ask you a favor to review this one?

[YJDoc2]

Hey @utam0k , I will review this by today or tomorrow 👍

[YJDoc2]

Hey @utam0k , Apologies for the delay 😓
I checked, and there are some issues / improvements that can be done

• it seems that provision script is running each time we are doing the make. eg, after first run of make containerd-test , when we run it second time, it still hangs the same amount of time. When removed the | true part, it shows the log default: Running provisioner: bootstrap (shell)... also when running second time. we should really not run it twice. changing it as follows should make it work as expected :

config.vm.provision "shell" do |s|
      s.inline = <<-SHELL
...

• can we have logs to be explicit in the test ? currently the logs are stored in a file, can we have them also printed to stdout, because otherwise it looks like the command has hanged without doing anything. For this removing the | true from first will also help.

Also a thing to note is I'm not sure how the syncing of youki dir with vm work, will need to check that it still works as expected after these changes.

Again, apologies for the delay, I unexpectedly got caught up in some work, and couldn't check this earlier.

[utam0k]

Hey @utam0k , Apologies for the delay sweat I checked, and there are some issues / improvements that can be done

• it seems that provision script is running each time we are doing the make. eg, after first run of make containerd-test , when we run it second time, it still hangs the same amount of time. When removed the | true part, it shows the log default: Running provisioner: bootstrap (shell)... also when running second time. we should really not run it twice. changing it as follows should make it work as expected :

config.vm.provision "shell" do |s|
      s.inline = <<-SHELL
...

• can we have logs to be explicit in the test ? currently the logs are stored in a file, can we have them also printed to stdout, because otherwise it looks like the command has hanged without doing anything. For this removing the | true from first will also help.

Also a thing to note is I'm not sure how the syncing of youki dir with vm work, will need to check that it still works as expected after these changes.

Again, apologies for the delay, I unexpectedly got caught up in some work, and couldn't check this earlier.

Thanks for your check. You don't need to say apologize. I am just grateful that you are always willing to help.
I haven't found the time yet to respond, so I'll address it later.

[YJDoc2]

lgtm 👍