Log result of the command before returning from main #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
==========================================
- Coverage 68.97% 68.96% -0.01%
==========================================
Files 119 119
Lines 12557 12560 +3
==========================================
+ Hits 8661 8662 +1
- Misses 3896 3898 +2 |
utam0k
reviewed
Oct 25, 2022
crates/youki/src/main.rs
Outdated
| }; | ||
|
|
||
| if let Err(ref e) = output { | ||
| log::error!("error in executing command : {:?}", e); |
There was a problem hiding this comment.
Suggested change
| log::error!("error in executing command : {:?}", e); | |
| log::error!("error in executing command: {:?}", e); |
utam0k
reviewed
Oct 25, 2022
crates/youki/src/main.rs
Outdated
| @@ -97,7 +97,7 @@ fn main() -> Result<()> { | |||
| let root_path = determine_root_path(opts.global.root)?; | |||
| let systemd_cgroup = opts.global.systemd_cgroup; | |||
|
|
|||
| match opts.subcmd { | |||
| let output = match opts.subcmd { | |||
There was a problem hiding this comment.
How about changing the name of the variable?
Suggested change
| let output = match opts.subcmd { | |
| let cmd_result = match opts.subcmd { |
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
YJDoc2
force-pushed
the
log_final_result
branch
from
08b47a9
to
e8c5d6a
Compare
|
@utam0k PTAL, have made both of the suggested changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will log the error if there was any when executing the command. This will help in trying to figure out what was the issue from the logs, as right now, we do not get any info about it from the logs. This was particularly irritating when trying to fix the containerd test, as it would just report
runtime exited with 1, and even the logs would not show anything.Signed-off-by: Yashodhan Joshi yjdoc2@gmail.com