Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script and prepare for release #1397

Merged
merged 7 commits into from
Dec 13, 2022

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Dec 6, 2022

This fixes the release script, and updates crate versions in preparation for release

README.md Show resolved Hide resolved
@YJDoc2 YJDoc2 requested a review from utam0k December 6, 2022 05:59
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #1397 (3bb3ee9) into main (28da7c0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   68.82%   68.82%           
=======================================
  Files         119      119           
  Lines       12779    12779           
=======================================
  Hits         8795     8795           
  Misses       3984     3984           

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YJDoc2 Feel free to merge this if it works fine on your forked repository

@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Dec 8, 2022

Hey @utam0k , actually this needs a few improvements, I'll update it as soon as I can

@utam0k utam0k self-requested a review December 8, 2022 12:40
@YJDoc2
Copy link
Collaborator Author

YJDoc2 commented Dec 13, 2022

@utam0k Please take a look
This should fix the script. Now when we push a new tag, it will run tests, create a release draft and publish the packages on crates.io (provided the secret is set to the crates io key correctly)
Also, I request you that for this PR, please do a squash and merge instead of normal merge, as there are a lot of temp/testing commits I had to do

@utam0k
Copy link
Member

utam0k commented Dec 13, 2022

I set my token into this repo as the secret.
publish the packages on crates.io (provided the secret is set to the crates io key correctly)

@utam0k utam0k merged commit 174448a into youki-dev:main Dec 13, 2022
@YJDoc2 YJDoc2 deleted the fix_release_script branch August 4, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants