skip cgroup v2 test of oci-tools #1406
Conversation
Signed-off-by: utam0k <k0ma@utam0k.jp>
utam0k
force-pushed
the
oci-cgroup-v2
branch
from
9e47a52
to
ce40384
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1406 +/- ##
==========================================
- Coverage 68.82% 68.81% -0.01%
==========================================
Files 119 119
Lines 12779 12779
==========================================
- Hits 8795 8794 -1
- Misses 3984 3985 +1 |
| if [ 0 -eq $(grep "# cgroupv2 is not supported yet " $logfile | wc -l ) ]; then | ||
| echo "Skip $case bacause oci-runtime-tools doesn't support cgroup v2" | ||
| continue; | ||
| fi | ||
| cat $logfile | ||
| exit 1 |
There was a problem hiding this comment.
Hey, I'm not sure I understand the purpose of this part. If we are checking for the test in check_environment function above, why do we need this here? Also, shouldn't the 0 -eq ... part be 0 -ne ... instead? If the grep finds occurrence, then wc will output a non-zero number, in which case we should be entering the condition, right?
There was a problem hiding this comment.
The logic is that if the test fails and the cause of the failure is not supported by the test in cgroup v2, the failure is ignored. I could have used check_environment, but I added this because of the uniform error messages.
|
Hey, @utam0k sorry for the delay, this looks good, so I'll go ahead and merge |
Ignore the failure because it cannot be tested in a cgroup v2 environment. For example, it fails with ubuntu 22.04.