Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the version of some crates we dependent #1500

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jan 22, 2023

Relaxing the version simplifies the introduction of crates.

Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k requested a review from a team January 22, 2023 08:43
@codecov-commenter
Copy link

Codecov Report

Merging #1500 (70b5d9f) into main (3f3c052) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
+ Coverage   68.78%   68.80%   +0.01%     
==========================================
  Files         120      120              
  Lines       13082    13082              
==========================================
+ Hits         8999     9001       +2     
+ Misses       4083     4081       -2     

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@utam0k , can you give me more context on this? For eg, where this will be useful or what is breaking because of this?

@utam0k
Copy link
Member Author

utam0k commented Jan 24, 2023

@YJDoc2 For example, suppose a user who wants to use libcontainer is already using oci-spec-rs and its version is 0.5.5.
The user cannot use libcontainer because libcontainer requires 0.6.0 of oci-spec-rs, or the version of oci-spec-rs must be increased.
This is prevented.

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 24, 2023

makes sense. I'll go ahead and merge this. Thanks :)

@YJDoc2 YJDoc2 merged commit fbd29f7 into youki-dev:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants