Cleanup state file path construction #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small cleanup creates a new static method `State::file_path()` which can be used to retrieve the state JSON file path. This makes the state module public and allows its usage from the `commands` module. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Furisto
approved these changes
Jul 26, 2021
|
Thanks @saschagrunert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Hey folks, I started looking into this project, because I didn't even know that it exists since a couple of days. I'm Sascha and I'm already working on a couple of other container related topics. I can probably spent some time contributing to this project during my hack days if you're still looking for contributors. 🙃
The change
This small cleanup creates a new static method
State::file_path()which can be used to retrieve the state JSON file path. This makes the state module public and allows its usage from thecommandsmodule.