add perf_event to cgroups v1 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furisto
requested changes
Jul 28, 2021
Furisto
reviewed
Jul 28, 2021
| use crate::cgroups::v1::Controller; | ||
| use oci_spec::{LinuxResources}; | ||
| use std::path::Path; | ||
|
|
There was a problem hiding this comment.
Suggested change
| use anyhow::Result; |
|
@fbrv Sorry for the confusion. With that suggestion I meant that you should add the use "above", not literally in the trait implementation. |
My fault, I haven't properly checked the suggestion, still learning rust :) hopefully in the next contributions will not happens anymore |
|
@fbrv You need to run cargo fmt, otherwise the check will not succeed. |
Run multiple times but for some reason it did not catch any error. Reinstalled rust and now seems working |
Furisto
approved these changes
Jul 28, 2021
|
🎉 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.