-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rsuid and rnosymfollow #1685
add rsuid and rnosymfollow #1685
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1685 +/- ##
=======================================
Coverage 68.77% 68.78%
=======================================
Files 121 121
Lines 13295 13295
=======================================
+ Hits 9144 9145 +1
+ Misses 4151 4150 -1 |
Hey @lengrongfu , Thanks a lot for this! I haven't taken a detailed look, but I had a general question : You have worked a lot with this part, and implemented several of these mount attr tests. Do you think we can refactor the test logic? What I mean is that is there a common "pattern" in all mount attr tests, that can be extracted in a function and then each individual attr test call this function ; so that individual attr test functions become simpler? And this is by no means a request to do it in this PR. If that can be done, we might first implement all the tests and then do that in a separate PR. I am just curious to know if that might be possible or not. Thanks :) |
I think it is possible, I create a refactoring issue. |
tests/rust-integration-tests/integration_test/src/tests/mounts_recursive/mod.rs
Outdated
Show resolved
Hide resolved
tests/rust-integration-tests/integration_test/src/tests/mounts_recursive/mod.rs
Show resolved
Hide resolved
07c3548
to
0fec613
Compare
tests/rust-integration-tests/integration_test/src/tests/mounts_recursive/mod.rs
Outdated
Show resolved
Hide resolved
0fec613
to
1707123
Compare
Signed-off-by: lengrongfu <1275177125@qq.com>
1707123
to
504b3d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lengrongfu Thanks!
issue: #1534