Generalize OCI spec root #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
force-pushed
the
oci-spec-root
branch
3 times, most recently
from
8001a73
to
75bd903
Compare
Furisto
reviewed
Jul 30, 2021
We now generalize and document the OCI `Spec` root structure. This means that some fields have been added and other are now optional. All corresponding usages of the new spec format have been changed and tests have been adapted. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
oci-spec-root
branch
from
75bd903
to
ade1c17
Compare
Furisto
approved these changes
Jul 30, 2021
|
@saschagrunert Looks good to me. As @utam0k has taken the lead on this, I will wait for his review before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now generalize and document the OCI
Specroot structure. This meansthat some fields have been added and other are now optional.
All corresponding usages of the new spec format have been changed and
tests have been adapted.