Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #145.
Note, the "LISTEN_FDS" and "LISTEN_PID" are not addressed in this PR. They are used for systemd and require us to also set the environment variables correctly. I or someone else will/should address these two in a different PR. This PR only addressed the
--preserve-fds
flag.Test:
Using busy box, before
--preserve-fds
flag, a number of fds that should be closed.after, correctly only leaving 0,1,2 fds. 10 is tty opened for shell.