youki exec should not clean up on error

[yihuaf]

Fix #1810

[codecov-commenter]

Codecov Report

Merging #1818 (a822e88) into main (1e894a0) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1818      +/-   ##
==========================================
- Coverage   68.64%   68.62%   -0.03%     
==========================================
  Files         121      121              
  Lines       13325    13327       +2     
==========================================
- Hits         9147     9145       -2     
- Misses       4178     4182       +4     

[YJDoc2]

Hey @yihuaf , what are your thoughts on moving the if-check inside match, instead of using it as a match guard ? There is no particular benefit to doing one instead of other, but I feel that it might more sense to move it inside like :

Ok(pid)=>...
Err(outer)=>{
     if matches!(....){
          // cleanup, if that errors , return outer.context(inner)
     }
     Err(outer)
}

I don't know if this will be better, so giving lgtm, because looks good 👍

[YJDoc2]

lgtm 👍

[utam0k]

May I ask you to write the integration test for this case?

[yihuaf]

May I ask you to write the integration test for this case?

Yes I was thinking about the same.

[yihuaf]

Merge this PR as is. I created #1819 to track the integration test. We have a few related bugs in this areas, so I want to go over the container life cycle tests with a new PR.

[utam0k]

@yihuaf 👍