Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cleanup container #1824

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

lengrongfu
Copy link
Collaborator

issue: #1817

@codecov-commenter
Copy link

Codecov Report

Merging #1824 (e9cd419) into main (1faa881) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
- Coverage   68.63%   68.61%   -0.03%     
==========================================
  Files         121      121              
  Lines       13327    13330       +3     
==========================================
- Hits         9147     9146       -1     
- Misses       4180     4184       +4     

@lengrongfu lengrongfu force-pushed the feat/running-cleanup-container branch from e9cd419 to 4e993f5 Compare April 18, 2023 13:36
@lengrongfu
Copy link
Collaborator Author

error[E0433]: failed to resolve: use of undeclared type `Errno`
   --> crates/libcontainer/src/process/container_main_process.rs:123:23
    |
123 |             if err == Errno::ECHILD {
    |                       ^^^^^ use of undeclared type `Errno`

😢

@yihuaf yihuaf self-requested a review April 19, 2023 04:18
Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to try to rebase to the latest main branch.

Signed-off-by: lengrongfu <1275177125@qq.com>
@lengrongfu lengrongfu force-pushed the feat/running-cleanup-container branch from 4e993f5 to 5ec6ed2 Compare April 23, 2023 13:04
@lengrongfu
Copy link
Collaborator Author

You may want to try to rebase to the latest main branch.

done.

@yihuaf yihuaf merged commit 59a888b into youki-dev:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants