Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate crossbeam since it is merged with std #1984

Merged
merged 1 commit into from
May 29, 2023

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented May 29, 2023

  • crossbeam is merged into std since 1.67
  • clean up a few unused dependencies

Signed-off-by: yihuaf <yihuaf@unkies.org>
@yihuaf yihuaf requested review from utam0k and a team May 29, 2023 06:47
@yihuaf yihuaf self-assigned this May 29, 2023
@yihuaf yihuaf requested a review from YJDoc2 May 29, 2023 06:47
@codecov-commenter
Copy link

Codecov Report

Merging #1984 (32f57e5) into main (4ba681f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
+ Coverage   65.29%   65.31%   +0.01%     
==========================================
  Files         129      129              
  Lines       14746    14746              
==========================================
+ Hits         9629     9631       +2     
+ Misses       5117     5115       -2     

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. All tests are passing, and integration tests check for hooks, so lgtm

@YJDoc2 YJDoc2 merged commit 7f6efb3 into youki-dev:main May 29, 2023
@yihuaf yihuaf deleted the yihuaf/clean_up branch May 29, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants