-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the test with kind to github action #2027
Conversation
6906c98
to
76ab585
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With regarding the path issue in justfile, we usually keep track of two path. One is the project root through git rev-parse
and another is the justfile is located, through justfile_directory
.
TOP := `git rev-parse --show-toplevel`
CWD := {{ justfile_directory() }}
Usually these two location is all we need to run all relative path into an absolute path. Usually, we want the justfile executed at the location of the justfile. Where we invoke the just
command should not matter. In this way, all command has a fixed and predictable path.
Otherwise LGTM.
I do not want to leave the case for using git. This is because of the dependence on git. We want to reduce the dependency. Also, I feel it is difficult to judge how to use with $ just -f ../justfile youki-dev
/home/utam0k/ghq/src/github.com/utam0k/youki/scripts/build.sh -o /home/utam0k/ghq/src/github.com/utam0k/youki -c youki
* FEATURES:
* features:
Finished dev [unoptimized + debuginfo] target(s) in 0.07s |
Signed-off-by: utam0k <k0ma@utam0k.jp>
I see. Is it because you are running the
I think if the current PR works as it stands, we should merge this and refactor justfile in follow ups. No need to block this PR further on jsutfile refactors since we will do those anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the nits with regarding to justfile
, we will deal with those in future refactoring. Let's get the test into CI first.
I had imaged the case in GH actions. |
No description provided.