Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export oci-spec in libcontainer #2068

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Jun 20, 2023

Fix #2066

  • re-export the oci-spec crate used by libcontainer as part of the libcontainer api
  • fix the oci-spec version, because oci-spec can have breaking changes with version bump.
  • remove oci-spec from youki crate dependency (this is the key here)

@yihuaf yihuaf marked this pull request as ready for review June 20, 2023 04:07
@codecov-commenter
Copy link

Codecov Report

Merging #2068 (f0c7c8a) into main (f4e7e30) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2068      +/-   ##
==========================================
- Coverage   64.81%   64.79%   -0.03%     
==========================================
  Files         129      129              
  Lines       14768    14769       +1     
==========================================
- Hits         9572     9569       -3     
- Misses       5196     5200       +4     

@yihuaf yihuaf requested review from utam0k, YJDoc2 and a team June 20, 2023 07:03
@yihuaf yihuaf self-assigned this Jun 20, 2023
The oci-spec crate can introduce breakage, so we should pin to specific
version we support.

Signed-off-by: yihuaf <yihuaf@unkies.org>
uses

Signed-off-by: yihuaf <yihuaf@unkies.org>
Signed-off-by: yihuaf <yihuaf@unkies.org>
Signed-off-by: yihuaf <yihuaf@unkies.org>
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great suggestion.

@utam0k utam0k merged commit 9ba5d8c into youki-dev:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] re-export the oci-spec from libcontainer
3 participants