turn on musl test in CI #2069
Merged
turn on musl test in CI #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2069 +/- ##
=======================================
Coverage 64.81% 64.81%
=======================================
Files 129 129
Lines 14768 14768
=======================================
Hits 9572 9572
Misses 5196 5196 |
Signed-off-by: yihuaf <yihuaf@unkies.org>
utam0k
reviewed
Jun 21, 2023
|
|
||
| # run cargo unittests | ||
| unittest: | ||
| cd ./crates | ||
| LD_LIBRARY_PATH=${HOME}/.wasmedge/lib cargo test --all --all-targets --all-features | ||
|
|
||
| # run permutated feature compilation tests | ||
| featuretest: | ||
| test-features: |
utam0k
reviewed
Jun 21, 2023
.github/workflows/main.yml
Outdated
| # The `setup-rust-toolchain` action will always choose toolchain file with | ||
| # no way to override. | ||
| - name: Setup Rust toolchain and cache | ||
| uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
Do we need to specify stable? I wonder because we have had rust-toolchain.toml.
There was a problem hiding this comment.
Good catch! I mis-read the documentation and thought the stable referred to the github action version... I will make the change.
Signed-off-by: yihuaf <yihuaf@unkies.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn the musl target testing in CI. At the moment, this is only for
libcontainersince there is an actual usecase fromauraeproject to compile libcontainer statically withmusl. I choose to put the musl in a separate job because of the unique requirement for the nightly toolchain. While it is easy for us to switch toolchains in the dev box, it proves to be not possible to mix toolchains with the existing rust github action setup. It is easier to create a new job with the specific toolchains required.