-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liboci additional flags and subcommands, as required by ociplex #2149
Commits on Jul 7, 2023
-
checkpoint: Add the missing options and change options order
Add the missing command-line options as documented for runc, and also reorder the options to match the documentation: https://github.com/opencontainers/runc/blob/main/man/runc-checkpoint.8.md (This does not mean that they are necessarily implemented) Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 8a37a91 - Browse repository at this point
Copy the full SHA 8a37a91View commit details -
create: Add no_pivot option, and change option order
The --no-pivot option is documented in https://github.com/opencontainers/runc/blob/main/man/runc-create.8.md Also change the options order in order to match the doc, this makes the code a bit easier to maintain. Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 6f93020 - Browse repository at this point
Copy the full SHA 6f93020View commit details
Commits on Jul 10, 2023
-
exec: Add missing command-line options
Add the missing command-line options for the exec subcommand. Reference: https://github.com/opencontainers/runc/blob/main/man/runc-exec.8.md Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 20431f3 - Browse repository at this point
Copy the full SHA 20431f3View commit details -
run: Add missing options to run subcommand
Also change the order to match the documentation in https://github.com/opencontainers/runc/blob/main/man/runc-run.8.md Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for c58b308 - Browse repository at this point
Copy the full SHA c58b308View commit details -
update: Add missing options to the update subcommand
Add command-line options as documented in https://github.com/opencontainers/runc/blob/main/man/runc-update.8.md Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for b7f54aa - Browse repository at this point
Copy the full SHA b7f54aaView commit details -
spec: Add options for the spec subcommand
Add the missing bundle option, as documented in https://github.com/opencontainers/runc/blob/main/man/runc-spec.8.md Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for e223403 - Browse repository at this point
Copy the full SHA e223403View commit details -
features: Add features subcommand
The 'features' subcommand is not publicly documented yet, but it was introduced in `runc` in opencontainers/runc#3296. Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 4c57517 - Browse repository at this point
Copy the full SHA 4c57517View commit details -
liboci-cli: Update README with information about features subcommand
The `features` subcommand is implemented in `runc`, but not documented. See opencontainers/runc#3296 Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> Suggested-by: Toru Komatsu <k0ma@utam0k.jp>
Configuration menu - View commit details
-
Copy full SHA for 136abf5 - Browse repository at this point
Copy the full SHA 136abf5View commit details -
list: Add missing command-line options
Add the command-line options documented in https://github.com/opencontainers/runc/blob/main/man/runc-list.8.md Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for e2dc283 - Browse repository at this point
Copy the full SHA e2dc283View commit details -
ociplex: Change order of exec subcommand to match documentation
We have to pick an order for the command-line options. Let's just use the same order as in the runc documentation (since this will also be the order shown by the command-line help) Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for d258324 - Browse repository at this point
Copy the full SHA d258324View commit details -
Document the
features
subcommand.The `features` subcommand is now officially documented. Update the links to the documentation. Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> Suggested-by: Toru Komatsu <k0ma@utam0k.jp>
Configuration menu - View commit details
-
Copy full SHA for a3ac34a - Browse repository at this point
Copy the full SHA a3ac34aView commit details -
Rename
parse_key_val
andparse_colon_separated_pair
It is better to describe the intent of the parsing than how it is done. Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> Suggested-by: Eric Fang <yihuaf@unkies.org>
Configuration menu - View commit details
-
Copy full SHA for 3b13f73 - Browse repository at this point
Copy the full SHA 3b13f73View commit details
Commits on Jul 12, 2023
-
The `Exec` structure is large compared to the others. This causes `just lint` to complain: ``` error: large size difference between variants --> crates/youki/src/main.rs:48:1 | 48 | / enum SubCommand { 49 | | // Standard and common commands handled by the liboci_cli crate 50 | | #[clap(flatten)] 51 | | Standard(liboci_cli::StandardCmd), | | --------------------------------- the second-largest variant contains at least 104 bytes 52 | | #[clap(flatten)] 53 | | Common(liboci_cli::CommonCmd), | | ----------------------------- the largest variant contains at least 320 bytes ... | 57 | | Completion(commands::completion::Completion), 58 | | } | |_^ the entire enum is at least 320 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `-D clippy::large-enum-variant` implied by `-D warnings` help: consider boxing the large fields to reduce the total size of the enum | 53 | Common(Box<liboci_cli::CommonCmd>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Boxing the `Exec` variant prevents this problem from happening. Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for bcabc06 - Browse repository at this point
Copy the full SHA bcabc06View commit details -
box up commands enum to avoid lints
Signed-off-by: yihuaf <yihuaf@unkies.org>
Configuration menu - View commit details
-
Copy full SHA for cdb860d - Browse repository at this point
Copy the full SHA cdb860dView commit details