Make container_args clone-able #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the container_args clone-able and remove the use of references. Container_args is passed to the intermediate and init process, so we need to make sure it can across the clone process boundry safely by allowing passing of the container_args ownership to the new process. Signed-off-by: yihuaf <yihuaf@unkies.org>
yihuaf
added
the
kind/cleanup
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
- Coverage 64.98% 64.93% -0.05%
==========================================
Files 129 129
Lines 14970 14979 +9
==========================================
- Hits 9728 9727 -1
- Misses 5242 5252 +10 |
utam0k
reviewed
Jul 23, 2023
| @@ -28,7 +28,7 @@ pub(super) struct ContainerBuilderImpl<'a> { | |||
| /// Id of the container | |||
| pub container_id: String, | |||
| /// OCI compliant runtime spec | |||
| pub spec: &'a Spec, | |||
| pub spec: Rc<Spec>, | |||
utam0k
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the container_args clone-able and remove the use of references. Container_args is passed to the intermediate and init process, so we need to make sure it can across the clone process boundry safely by allowing passing of the container_args ownership to the new process.