Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #209, pass root-readonly #224

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Conversation

chenyukang
Copy link
Collaborator

close #209

@chenyukang
Copy link
Collaborator Author

Btw, add pattern matching for running specific tests, it's useful when trying to debug specific test:

yukang@mango:~/youki$ ./integration_test.sh readonly
Running linux_readonly_paths/linux_readonly_paths.t
Running root_readonly_true/root_readonly_true.t

@utam0k
Copy link
Member

utam0k commented Aug 24, 2021

Btw, add pattern matching for running specific tests, it's useful when trying to debug specific test:

yukang@mango:~/youki$ ./integration_test.sh readonly
Running linux_readonly_paths/linux_readonly_paths.t
Running root_readonly_true/root_readonly_true.t

This is a great change because I used to change integration.sh every time! If you don't mind, could you put an example of how to use it somewhere in the README or integraiton.sh?

@chenyukang
Copy link
Collaborator Author

Btw, add pattern matching for running specific tests, it's useful when trying to debug specific test:

yukang@mango:~/youki$ ./integration_test.sh readonly
Running linux_readonly_paths/linux_readonly_paths.t
Running root_readonly_true/root_readonly_true.t

This is a great change because I used to change integration.sh every time! If you don't mind, could you put an example of how to use it somewhere in the README or integraiton.sh?

I added an example in README.

@chenyukang chenyukang closed this Aug 25, 2021
@chenyukang chenyukang reopened this Aug 25, 2021
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@utam0k utam0k merged commit 1485606 into youki-dev:main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass the root_read_only integration test
2 participants