Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov #232

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Add codecov #232

merged 4 commits into from
Aug 31, 2021

Conversation

chenyukang
Copy link
Collaborator

Fix #226

@chenyukang
Copy link
Collaborator Author

chenyukang commented Aug 26, 2021

Not sure the whole configuration is right, maybe needs more investigation tomorrow.
At least, we need to update the token in the badge.

@chenyukang
Copy link
Collaborator Author

@utam0k Please merge it and update the badge. https://app.codecov.io/gh/containers/youki/settings
I don't have the permissions.

env:
CARGO_INCREMENTAL: '0'
RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests'
RUSTDOCFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the cargo test run twice?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the cargo test run twice?

It's in different directories, one in top-level and one in cgroups, I didn't change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, wrong working directory. I overlooked it.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@1485606). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage        ?   38.22%           
=======================================
  Files           ?       15           
  Lines           ?     1371           
  Branches        ?      374           
=======================================
  Hits            ?      524           
  Misses          ?      678           
  Partials        ?      169           

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@utam0k utam0k merged commit ef4b793 into youki-dev:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introducing Code Coverage
4 participants