Refactor test dir structure #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use several things from test_framework and even integration_test for additional tests such as podman rootless and wasm tests Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
YJDoc2
force-pushed
the
test/refactor-dir-structure
branch
from
550770a
to
bbe6359
Compare
utam0k
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the existing rust-integration-tests/* dirs, specifically
integration_test,runtimetestandtest_frameworkone level up, i.e. in thetests/dir. That way these, specificallytest_frameworkand some other stuff(not in this PR, I'm planning a separate one) into multiple tests. In "other stuff" I am considering extracting youki create-run-stop-delete functions fromintegration_testinto a cratetest_util, as well as add podman create-start-run-delete function into thetest_utilcrate. That way we can use them and test_framework to add (proper) rootless podman tests and wasm workload tests.As for this PR, this only moved stuff around, no actual code-change is done, and updates docs and scripts to account for the new dir structure.
Also, As utam0k mentioned in discord, it is a good time to rename integration_test to something else, so if any suggestions, please add in comments, and I'll update accordingly.