Use raw syscalls to avoid sporadic hangs #2425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setgroups
/setresgid
/setresuid
functions innix
/libc
are not safe to call afterclone
/clone3
.These function use a blocking mechanism that synchronises across all threads in the process.
To do this
libc
(glibc
/musl
) needs to do some bookkeeping, which breaks on the new process afterclone
.See the discussion in containerd/runwasi#347 for more details.
This PR worksaround that issue by using raw syscalls for
setgroups
/setresgid
/setresuid
.This is generally not safe, as the raw syscalls only affect the calling thread and not the whole process.
It is safe to do so in this case because at the point when they are called in libcontainer the init process only has one thread.