Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libcgroups): clean up 'libcgroups::v1::manager' #2530

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix(libcgroups): clean up 'libcgroups::v1::manager' #2530

merged 1 commit into from
Nov 17, 2023

Conversation

xiaoyang-sde
Copy link
Contributor

@xiaoyang-sde xiaoyang-sde commented Nov 14, 2023

This pull request cleans up the 'libcgroups::v1::manager' module.

  • Remove the redundant use crate::v1::ControllerType statement
  • Replace for subsys in &self.subsystems with for (ctrl_type, cgroup_path) in &self.subsystems (because self.subsystems is a HashMap)
  • Remove redundant invocations of Result::map_err()

@xiaoyang-sde xiaoyang-sde changed the title fix(libcgroups): cleanup 'libcgroups::v1::manager' fix(libcgroups): clean up 'libcgroups::v1::manager' Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Merging #2530 (d6a6cd3) into main (7b4160a) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2530      +/-   ##
==========================================
- Coverage   65.87%   65.87%   -0.01%     
==========================================
  Files         133      133              
  Lines       16868    16867       -1     
==========================================
- Hits        11112    11111       -1     
  Misses       5756     5756              

Signed-off-by: Xiaoyang Liu <siujoeng.lau@gmail.com>
@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 17, 2023
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@utam0k utam0k merged commit fb05b7b into youki-dev:main Nov 17, 2023
14 of 15 checks passed
@xiaoyang-sde xiaoyang-sde deleted the libcgroups-v1 branch November 17, 2023 15:43
This was referenced Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants